[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18480 [Tor]: Some tor time functions don't work after 2037 with 32-bit time_t

#18480: Some tor time functions don't work after 2037 with 32-bit time_t
------------------------------+------------------------------------
 Reporter:  teor              |          Owner:
     Type:  defect            |         Status:  new
 Priority:  Medium            |      Milestone:  Tor: 0.2.9.x-final
Component:  Tor               |        Version:
 Severity:  Normal            |     Resolution:
 Keywords:  integer-overflow  |  Actual Points:
Parent ID:                    |         Points:
  Sponsor:                    |
------------------------------+------------------------------------

Comment (by teor):

 I've added some unit tests in #18479 for these functions, and added
 comments where the functions should indicate failure, but don't. Search
 for "should indicate failure on overflow" in test_util_time and
 test_util_parse_http_time.

 Fixing this issue probably means making the functions listed in the ticket
 description return an int (-1) for failure, rather than always returning
 void or zero.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18480#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs