[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18515 [Tor]: Refactoring routerparse.c/.h, hidden services parser in a seperate file

#18515: Refactoring routerparse.c/.h, hidden services parser in a seperate file
-------------------------+------------------------------------
 Reporter:  malekbr      |          Owner:  malekbr
     Type:  enhancement  |         Status:  needs_information
 Priority:  Very Low     |      Milestone:  Tor: 0.2.9.x-final
Component:  Tor          |        Version:
 Severity:  Trivial      |     Resolution:
 Keywords:  tor-hs       |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:
-------------------------+------------------------------------
Changes (by dgoulet):

 * keywords:   => tor-hs
 * status:  needs_review => needs_information


Comment:

 Food for thoughts. So I like this move in general. Although, I think we
 could do better. Those parsing functions are for the HS descriptor so how
 about we create a `renddesc.{c|h}` file and move parsing + encoding
 functions there (and maybe all related functions to descriptor)?

 I fear that rendparse.c (name) doesn't have the extra indication that this
 is for descriptor. We are not parsing HS cells in there for instance.

 (This is the approach we took for next generation hidden service that is
 have `hs_descriptor.{c|h}` for all descriptor related API/ABI.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18515#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs