Re: [tor-bugs] #18368 [Tor]: Don't call a consensus a "vote" in log messages

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#18368: Don't call a consensus a "vote" in log messages
------------------------------------+------------------------------
 Reporter:  nickm                   |          Owner:  nickm
     Type:  defect                  |         Status:  needs_review
 Priority:  Medium                  |      Milestone:
Component:  Tor                     |        Version:
 Severity:  Minor                   |     Resolution:
 Keywords:  must-fix-before-028-rc  |  Actual Points:
Parent ID:  #17668                  |         Points:
 Reviewer:                          |        Sponsor:
------------------------------------+------------------------------

Comment (by sysrqb):

 The comment in src/or/dircollate.h seems like it has an extraneous "an",
 and this ticket's title seems different from the patch. Unrelatedly, the
 \file and \brief in dircolate.h are wrong.

 Other than those, it looks good to me. At least within the local functions
 these changes seems good, but I didn't re-read through all the voting
 logic to make sure nothing was missed and I didn't test this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18368#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs