[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18616 [Tor]: Bug: Node search initiated by. Stack trace:
#18616: Bug: Node search initiated by. Stack trace:
-------------------------------------------------+-------------------------
Reporter: toralf | Owner:
Type: defect | Status:
Priority: Medium | needs_revision
Component: Tor | Milestone: Tor:
Severity: Normal | 0.2.8.x-final
Keywords: regression, must-fix-before-028-rc, | Version: Tor:
TorCoreTeam201603 | 0.2.8.1-alpha
Parent ID: | Resolution:
Reviewer: | Actual Points:
| Points:
| Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):
* status: needs_review => needs_revision
Comment:
The patch sounds about right imo if `dir_server_mode` now calls
`router_should_be_directory_server`, we end up doing twice here:
{{{
ri->supports_tunnelled_dir_requests = dir_server_mode(options) &&
router_should_be_directory_server(options, ri->dir_port);
}}}
Maybe this above should be fixed also by simply removing the extra call.
It sounds right that we stop advertising our directory support when our
AccountinMax has been reached or our bandwidth is not enough all of the
sudden.
Putting this one in `needs_revision` because if we are comfortable with
this patch, the above should be fixed.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18616#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs