[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #21309 [Applications/Tor Browser]: Fix Omnibox for TBB/52ESR
#21309: Fix Omnibox for TBB/52ESR
-------------------------------------------------+-------------------------
Reporter: arthuredelstein | Owner: tbb-
| team
Type: defect | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ff52-esr, tbb-7.0-must, | Actual Points:
TorBrowserTeam201703R |
Parent ID: #20680 | Points:
Reviewer: | Sponsor:
| Sponsor4
-------------------------------------------------+-------------------------
Comment (by mcs):
Replying to [comment:12 arthuredelstein]:
> For some reason removing all but the default entry doesn't work, even
for US English. nsSearchService.js is pretty convoluted so I'm not sure
why. My current approach is to change all locales we deploy to include the
same search engine list, and then rely on our #18915 patches for tor-
browser-bundle.git to copy these search engines and the list to each
locale xpi. It's awkward, but it seems like it should work. Unfortunately
I'm having trouble getting tor-browser-bundle.git to build right now, so I
haven't fully tested this. But here is the patch in any case:
>
> https://github.com/arthuredelstein/tor-browser/commit/21309+1
This patch looks okay, except should the URLs in ddg-onion.xml be https
instead of http?
Regarding the changes needed for packaging (builders/tor-browser-
bundle.git), Kathy and I wonder if it will work to simply remove
`browser/chrome/$LOCALE/locale/browser/searchplugins` from each of the
language packs. But we have not tried it.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21309#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs