[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25260 [Applications/Tor Launcher]: Merge mozbuild files into tor-launcher.git



#25260: Merge mozbuild files into tor-launcher.git
---------------------------------------+-----------------------
 Reporter:  sysrqb                     |          Owner:  brade
     Type:  enhancement                |         Status:  new
 Priority:  Medium                     |      Milestone:
Component:  Applications/Tor Launcher  |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:                             |  Actual Points:
Parent ID:  #24856                     |         Points:
 Reviewer:                             |        Sponsor:
---------------------------------------+-----------------------

Comment (by arthuredelstein):

 These patches look good to me in general (though I haven't tested them
 yet). I'm wondering if it's necessary to add moz.build file, or if we
 could still build with the traditional makefile inside torlauncher.git,
 and then just copy the .xpi to the appropriate place when we bundle
 everything together in tor-browser-build.git?

 Keeping the torlauncher and torbutton extension builds independent of the
 Mozilla build system (if possible) seems like it will give us more
 flexibility. For example, I sometimes hack on torbutton.git without having
 a clone of mozilla-central present. I just copy the XPI to an existing Tor
 Browser build. And I occasionally post the .XPI for other people to test.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25260#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs