[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25444 [Metrics/Library]: Add jaxb dependency explicitly for java 9



#25444: Add jaxb dependency explicitly for java 9
-----------------------------+------------------------------
 Reporter:  iwakeh           |          Owner:  metrics-team
     Type:  defect           |         Status:  new
 Priority:  Low              |      Milestone:
Component:  Metrics/Library  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:  #25443           |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------

Comment (by karsten):

 I think the only class we're using from that library is
 `javax.xml.bind.DatatypeConverter`, and the reason why we're using that
 is:

 {{{
 commit 1734d1663944acf20d275ac4f66be87d497ab7cb
 Author: Karsten Loesing <karsten.loesing@xxxxxxx>
 Date:   Wed Aug 5 13:53:38 2015 +0200

     Remove commons-codec dependency.

     Turns out that Java already comes with default implementations of
     SHA-1, SHA-256, and Base64 that we can use.
 }}}

 It was simply convenient that this class existed in Java SE. But before we
 add a new dependency, maybe we should simply switch back to Apache Commons
 Codec.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25444#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs