[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12377 [Core Tor/Tor]: get_interface_address6() behaviour iff all interface addresses are internal

#12377: get_interface_address6() behaviour iff all interface addresses are internal
-------------------------------------------------+-------------------------
 Reporter:  rl1987                               |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  unspecified
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-relay, address-detection,        |  Actual Points:
  review-group-34                                |
Parent ID:                                       |         Points:  1
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 I got this branch to merge in latest master. I modified several things to
 make it merge and also to our coding standards. Make check is happy now.

 I'm happy with this branch. Linux only and I'm also curious to see it pass
 on Jenkins with BSD/OS X/Windows of this world.

 @nickm, I think it would be nice if you go over it at least in terms of
 code structure/compat layer, if it is satisfying to you.

 Branch: `ticket12377_034_01`
 PR: https://github.com/torproject/tor/pull/28

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12377#comment:39>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs