[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29537 [Core Tor/Tor]: verify intptr_t round-trip through void *

#29537: verify intptr_t round-trip through void *
----------------------------------------+----------------------------------
 Reporter:  catalyst                    |          Owner:  (none)
     Type:  defect                      |         Status:  needs_review
 Priority:  Medium                      |      Milestone:  Tor:
                                        |  0.4.1.x-final
Component:  Core Tor/Tor                |        Version:
 Severity:  Normal                      |     Resolution:
 Keywords:  portability technical-debt  |  Actual Points:
Parent ID:                              |         Points:
 Reviewer:  catalyst, teor              |        Sponsor:
----------------------------------------+----------------------------------
Changes (by teor):

 * reviewer:  catalyst => catalyst, teor


Comment:

 I did a quick review and made some suggestions,

 I think testing negative ints is important, testing every bit is
 potentially useful and harmless, and putting the casts in another module
 improves the reliability of the test under optimisation (and is also
 harmless).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29537#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs