[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25140 [Core Tor/Tor]: Parse only .torrc files in torrc.d directory
#25140: Parse only .torrc files in torrc.d directory
-------------------------------------------------+-------------------------
Reporter: iry | Owner:
| Jigsaw52
Type: task | Status:
| needs_revision
Priority: High | Milestone: Tor:
| 0.4.1.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.3.3.1-alpha
Severity: Major | Resolution:
Keywords: 034-triage-20180328, | Actual Points:
035-removed-20180711 |
Parent ID: | Points:
Reviewer: ahf | Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):
* status: needs_review => needs_revision
Comment:
Thanks for this code! I did a review.
It seems like the documentation and tests are incomplete.
I'd like to see documentation for:
* escaping wildcards (for non-Windows)
* globs are only allowed at the end of paths (for Windows)
I'd like to see more tests for these cases, and for the dot-file case,
where the documentation does not match the code.
I don't know what will happen when this code interacts with the sandbox.
I also didn't review memory management in detail.
Please make sure it has been tested with "Sandbox 1" and ASan. It might be
useful to have an integration test script in src/test that launches tor
with some example configs. The existing sh and py files in src/test are
good examples to follow.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25140#comment:39>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs