[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #33330 [Circumvention/Snowflake]: Use Go modules for Snowflake



#33330: Use Go modules for Snowflake
-------------------------------------+------------------------
 Reporter:  cohosh                   |          Owner:  cohosh
     Type:  defect                   |         Status:  closed
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:  fixed
 Keywords:                           |  Actual Points:  .2
Parent ID:                           |         Points:  .2
 Reviewer:                           |        Sponsor:
-------------------------------------+------------------------

Comment (by cohosh):

 Replying to [comment:8 dcf]:
 > Replying to [comment:6 cohosh]:
 > > Yeah this is weird. I'm still not sure why dependencies are sometimes
 added with `// indirect`. As far as I can tell, they are mostly not
 necessary to get a working build.
 [https://github.com/golang/go/wiki/Modules#why-does-go-mod-tidy-record-
 indirect-and-test-dependencies-in-my-gomod This resource] suggests that
 they are required by dependencies that don't have module support, but I
 suspect there's a bug in how they determine that.
 >
 > I think I see now. github.com/golang/protobuf and golang.org/x/text are
 only used by tests, and they are not packages themselves, but modules
 containing packages. The actual packages are
 github.com/golang/protobuf/proto and golang.org/x/text/secure/bidirule.
 `go mod why -m` searches for subpackages of that form.

 Hm okay. I suppose that explains why Tor Browser still builds despite
 leaving out some packages like golang.org/x/sync weren't necessary when we
 originally added pion in #28942.

 I'm in the middle of another pion update for #33576, I might see if there
 are dependencies we can prune there.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33330#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs