[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33072 [Core Tor/Tor]: When under load, give 503 aggressively for dirport requests without compression
#33072: When under load, give 503 aggressively for dirport requests without
compression
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: dgoulet
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: network-health 043-should consider- | Actual Points:
backport-after-0434 |
Parent ID: #33018 | Points:
Reviewer: teor | Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):
* status: needs_review => needs_revision
* keywords: network-health 043-should => network-health 043-should
consider-backport-after-0434
* reviewer: nickm, arma => teor
Comment:
I think this change looks good, but I am not sure about allowing all
compressed requests. I think we should check the write bucket for
compressed requests, so that we prioritise requests in this order, by
default:
* voting
* compressed requests
* uncompressed requests
But if that's not possible, or it would take a lot of code changes, I'm
happy to prioritise compressed requests (including voting) over
uncompressed requests.
Also, please remove the binary files from the PR. Do we need to update the
.gitignore to exclude *.a ?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33072#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs