[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] Re: [Tor Bug Tracker] #1384: Document what happens if options are defined more than once



#1384: Document what happens if options are defined more than once
----------------------------+-----------------------------------------------
 Reporter:  Sebastian       |       Owner:     
     Type:  defect          |      Status:  new
 Priority:  minor           |   Milestone:     
Component:  Tor-Tor client  |     Version:     
 Keywords:  Documentation   |  
----------------------------+-----------------------------------------------
Changes (by nickm):

  * priority:  major => minor


Comment:

 It seems reasonable to disallow any options that do not have a defined
 meaning when they appear more than once to appear more than once in a
 single configuration file.

 This should probably happen in config_assign(), between pass 1 and pass 2.
 The check could be as simple as making a bitarray with as many entries as
 are in fmt->vars, then iterating over the list of configuration options
 and using config_find_option to look up the index of each one, using the
 bitarray to track which ones we've already seen.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1384#comment:1>
Tor Bug Tracker <https://trac.torproject.org/>
The Tor Project: anonymity online