Re: [tor-bugs] #3076 [Tor Client]: Implement 'SocksPort auto' and 'ControlPort auto'

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#3076: Implement 'SocksPort auto' and 'ControlPort auto'
-------------------------+--------------------------------------------------
 Reporter:  mikeperry    |          Owner:                    
     Type:  enhancement  |         Status:  needs_review      
 Priority:  major        |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client   |        Version:                    
 Keywords:               |         Parent:  #2264             
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by rransom):

 In `control_ports_write_to_file` in
 [https://gitweb.torproject.org/nickm/tor.git/commitdiff/1a9a29e73efa1771f772e5a411da15d643c56afe
 commit 1a9a29e73efa1771f772e5a411da15d643c56afe], you're joining strings
 using the empty string as a separator; you want to use `"\n"` instead.

 Also, I don't think you want to log the multi-line string that you're
 about to write to the file at level notice.

 Also, you should free the smartlist when you're done with it.

 In `tor_cleanup`, the âRemove our pid file.â comment is misplaced; you
 could move and expand it or nuke it.

 In
 [https://gitweb.torproject.org/nickm/tor.git/commitdiff/da3f3a81e276812f49a66416576e85779fbd6580
 commit da3f3a81e276812f49a66416576e85779fbd6580],
 ControlPortFileGroupReadable deserves a changes/ entry.

 Other than that, looks good.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3076#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs