[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5534 [Tor Directory Authority]: Make bridge authorities add "a" lines to router status entries

#5534: Make bridge authorities add "a" lines to router status entries
-------------------------------------+--------------------------------------
 Reporter:  ln5                      |          Owner:  ln5               
     Type:  enhancement              |         Status:  needs_revision    
 Priority:  normal                   |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Directory Authority  |        Version:                    
 Keywords:                           |         Parent:  #4563             
   Points:                           |   Actualpoints:                    
-------------------------------------+--------------------------------------
Changes (by asn):

  * status:  needs_review => needs_revision


Comment:

 I looked at the branch briefly. Two little things:

 a) `changes/bug5891` seems to have some git conflict strings inside.
 b) ''Usually'' prefer `fmt_addr()` instead of `tor_addr_to_str()` when
 it's possible. In `routerstatus_format_entry()` I think you are
 overwriting `buf` in your call to `tor_addr_to_str()`. Check out how
 functions like `connection_proxy_connect()` are using `fmt_addr()` in
 `snprintf`.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5534#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs