[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5528 [Tor]: router->address is redundant with router->addr

#5528: router->address is redundant with router->addr
-----------------------------+----------------------------------------------
 Reporter:  arma             |          Owner:                    
     Type:  enhancement      |         Status:  needs_review      
 Priority:  normal           |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor              |        Version:                    
 Keywords:  tor-client easy  |         Parent:                    
   Points:                   |   Actualpoints:                    
-----------------------------+----------------------------------------------

Comment(by andrea):

 Hmm; the change in the unit test seems to hint at a problem with this:
 sometimes router->address is set from the public address rather than the
 address we're listening on, and thus does not always match router->addr.
 Are we okay with changing every instance of anything using router->address
 to use the actual listener address?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5528#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs