[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17983 [Core Tor/Tor]: Build tor with -ftrapv by default
#17983: Build tor with -ftrapv by default
-------------------------------------------------+-------------------------
Reporter: teor | Owner: nickm
Type: enhancement | Status:
Priority: High | needs_revision
Component: Core Tor/Tor | Milestone: Tor:
Severity: Normal | 0.2.9.x-final
Keywords: tor-sponsorS-orphan, | Version:
TorCoreTeam201605, TorCoreTeam- | Resolution:
postponed-201604, review-group-1 | Actual Points:
Parent ID: | Points: small
Reviewer: special | Sponsor:
| SponsorS-can
-------------------------------------------------+-------------------------
Changes (by special):
* status: needs_review => needs_revision
* reviewer: => special
Comment:
Seems like a good plan to me. I trust and did not check that you've found
all of the code that must be constant time. The /bin/true problem is the
only real issue I see.
ce854a8d22d5056cc1a47a0d4d4251f93a0c667c
OS X doesn't know /bin/true, and warns about this. Can you use the 'true'
builtin instead?
> + src/common/libor-ctime.a \
These lines in src/common/include.am use space indent, but the surrounding
lines are tab indented.
b1dce55b8236cc7ecf66f87c0bd96b0dcf874fcc
Why does `src_test_test_memwipe_LDFLAGS` use `@CFLAGS_BUGTRAP@` if it's
excluded from CFLAGS?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17983#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs