[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22128 [Core Tor/Tor]: Refactor body of connection_dir_client_reached_eof()

#22128: Refactor body of connection_dir_client_reached_eof()
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  .1
Parent ID:  #21650        |         Points:  .1
 Reviewer:                |        Sponsor:  Sponsor4
--------------------------+------------------------------------
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Looks good to me.  I do see some places that could use further
 refactoring, like some of the complicated logging calls.  Also the if-else
 chains dealing with stringifying compression methods could go into a
 switch-statement in a helper function.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22128#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs