[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #22252 [Core Tor]: get_options_mutable: Assertion global_options failed; SIGABRT
#22252: get_options_mutable: Assertion global_options failed; SIGABRT
----------------------+------------------------------------
Reporter: stze | Owner:
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.3.1.x-final
Component: Core Tor | Version: Tor: unspecified
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
----------------------+------------------------------------
Comment (by arma):
Short-term fixes would be to either introduce the 'options' parameter to
all of these functions too, or to refactor circuit_build_times_disabled()
so it returns 1 as soon as it discovers a reason to return 1, so we check
consensus_disabled last, since this chain of functions only happens when
!options->LearnCircuitBuildTimeout. That latter fix is probably the right
one for 0.3.0, if we choose to fix this bug there.
For 0.3.1 or 0.3.2, I'm curious if we have ideas for better fixes, since
right now the requirement is "while validating or applying options, never
call anything that would cause a call to get_options()" which is tricky to
stick to because so many things call get_options().
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22252#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs