[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #1922 [Core Tor/Tor]: torrc.d-style configuration directories
#1922: torrc.d-style configuration directories
-------------------------------------------------+-------------------------
Reporter: aa138346 | Owner:
| Jigsaw52
Type: enhancement | Status:
| needs_review
Priority: Low | Milestone: Tor:
| 0.3.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-client, intro, | Actual Points:
tor-03-unspecified-201612 |
Parent ID: | Points: medium
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by Jigsaw52):
I don't think unescape_string() is a good function to unquote the paths
because:
1. C escape sequences will be unescaped. This is a problem on Windows,
where a path like C:\tor would become C:<TAB>or
2. Backslashes need to be escaped. On Windows this would make paths a
mess.
3. A path ending with backslash (e.g.: "C:\Programs and
Files\tor\torrc.d\") would cause problems too.
That is why I created a new function. None of the unescaping functions I
found would handle these cases well.
You are correct about the leak. I fixed it. Thanks for finding it.
I also added config-can-saveconf to the changes file.
The new branch is here: https://github.com/Jigsaw52/tor/tree/torrc-dir-
fix-1922_squashed2
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1922#comment:82>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs