Re: [tor-bugs] #26022 [Metrics/Statistics]: Fix a flaw in the noise-removing code in our onion service statistics

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#26022: Fix a flaw in the noise-removing code in our onion service statistics
--------------------------------+------------------------------
 Reporter:  karsten             |          Owner:  metrics-team
     Type:  defect              |         Status:  needs_review
 Priority:  Medium              |      Milestone:
Component:  Metrics/Statistics  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+------------------------------

Comment (by asn):

 Hey Karsten,

 nice research! It's been a while since we looked at this stuff, so here
 are a
 few questions as I try to understand what's going on:

 a) I'm trying to understand the rounding step and it's significance. Do
 you
    remember what we meant by ''The idea is that it's most likely that
 noise was
    added to the closest right side of a bin than to the right side of
 another
    bin.''?

 b) Why do we think that the result of that division should be floored
 towards
    infinity? Is it because the graph looks weird?

 c) How did you produce that graph? I agree it doesn't look good.

 d) You say ''Right now, we're handling all negative reported values wrong
 by
    adding 1 binSize to them which we shouldn't do.''. Where do we do that,
 and
    why?

 Thanks! :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26022#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs