[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26155 [Core Tor/Tor]: Bandwidth file Timestamp is the latest scanner result, not the file creation time

#26155: Bandwidth file Timestamp is the latest scanner result, not the file
creation time
----------------------------------+------------------------------------
 Reporter:  teor                  |          Owner:  teor
     Type:  defect                |         Status:  needs_revision
 Priority:  Medium                |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor          |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:  tor-spec, tor-bwauth  |  Actual Points:
Parent ID:                        |         Points:
 Reviewer:                        |        Sponsor:
----------------------------------+------------------------------------

Comment (by teor):

 I reviewed your changes.
 I noticed a missed "scanner".
 I also noticed an ambiguity introduced by using "generator".

 Please flip to merge_ready once you're done.

 Replying to [comment:4 juga]:
 > Hmm, timestamp and version have fixed positions,

 Timestamp needs to be the first line because that's what all tor
 implementations expect.
 Version needs to be the second line because it can change how the rest of
 the file is parsed.

 > but i don't remember now if we commented that software and
 software_version should be in 3rd and 4th positions or they can be in
 arbitrary positions.

 We have always said they can be in arbitrary positions.

 Is there any reason that they need to be near the top?
 Otherwise, let's not have a restriction.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26155#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs