[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24309 [Applications/Tor Browser]: Activity 4.1: Improve how circuits are displayed to the user



#24309: Activity 4.1: Improve how circuits are displayed to the user
--------------------------------------------+--------------------------
 Reporter:  isabela                         |          Owner:  tbb-team
     Type:  defect                          |         Status:  closed
 Priority:  High                            |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:  fixed
 Keywords:  ux-team, TorBrowserTeam201805R  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:  antonela                        |        Sponsor:
--------------------------------------------+--------------------------

Comment (by gk):

 Replying to [comment:64 arthuredelstein]:
 > Replying to [comment:62 gk]:
 > > Okay, I cherry-picked ef3476c5068d8597084c781a25792ce9ccef378c and
 fixed two typos in a follow-up commit
 (a3447ddb13c279e7e4c384610b98a045e7f932bb). Thanks, great work!
 > >
 > > What's the idea behind the "const-ification" in the other commit?
 FWIW: I am not sure whether this is actually bound to this bug (given you
 used the same bug number).
 >
 > Something igt0 suggested when he reviewed the patch. Technically I
 should be using `const` often where I am using `let`. Maybe it's better to
 ignore this patch for now and we can decide whether to constify the whole
 codebase at some point.

 I opened #26184 to gather our thoughts for a "constification".

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24309#comment:67>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs