[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30359 [Core Tor/Stem]: Stem PEP8 compliant



#30359: Stem PEP8 compliant
---------------------------+------------------------
 Reporter:  0xrichard      |          Owner:  atagar
     Type:  enhancement    |         Status:  new
 Priority:  Low            |      Milestone:
Component:  Core Tor/Stem  |        Version:
 Severity:  Minor          |     Resolution:
 Keywords:  dev            |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+------------------------

Comment (by 0xrichard):

 > ...  before investing your time.

 I had a great day, found some things I would've done differently, like
 putting stuff in __init__.py

 > Decide which of the above PEP8 compliance rules you feel strongly that
 we should follow.

 [flake8]
 ignore = E501,W504,F811,F821,W605,E402,F401,F405,E131,W503,E265,E999,F403

 > File a ticket to discuss why you think we should change it.
 Just did

 > Once we've established a consensus on following the rule remove its
 ignore configuration from the file mentioned above. Stem's tests should
 now cite all the spots where we don't comply with it.

 That's up to you, you tell me. I got time :)

 > Make the adjustments (like your patch does) to correct the compliance
 issues.

 I'd be happy to

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30359#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs