[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30359 [Core Tor/Stem]: Stem PEP8 compliant



#30359: Stem PEP8 compliant
---------------------------+------------------------
 Reporter:  0xrichard      |          Owner:  atagar
     Type:  enhancement    |         Status:  new
 Priority:  Low            |      Milestone:
Component:  Core Tor/Stem  |        Version:
 Severity:  Minor          |     Resolution:
 Keywords:  dev            |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+------------------------

Comment (by atagar):

 > I had a great day, found some things I would've done differently

 Fantastic! Glad you found this fruitful. :)

 >> File a ticket to discuss why you think we should change it.
 >
 > Just did

 Yup! But we still need to discuss both **what** stylistic aspects you
 think we should change and **why**. Stem should be conformant with PEP8
 except in the following respects...

 * Two space indentation rather than four.
 * Bare except clauses.
 * Space between keywords and arguments.

 Which of these do you strongly feel we should change and why?

 > and the circular imports :(

 If you make a separate commit with this and repro steps for triggering the
 circular dependency bug I'd be happy to chat.

 > and switch to pytest with fixtures

 What benefit will that provide over what we presently have?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30359#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs