[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28152 [Applications/GetTor]: Gettor code refactor with Python Twisted

#28152: Gettor code refactor with Python Twisted
---------------------------------+------------------------------
 Reporter:  ilv                  |          Owner:  hiro
     Type:  enhancement          |         Status:  needs_review
 Priority:  Very High            |      Milestone:
Component:  Applications/GetTor  |        Version:
 Severity:  Major                |     Resolution:
 Keywords:  gettor-roadmap       |  Actual Points:
Parent ID:  #28232               |         Points:
 Reviewer:  phw                  |        Sponsor:  Sponsor19
---------------------------------+------------------------------

Comment (by phw):

 I think it's a great idea to document the code, but it's orthogonal to my
 point that we should strive for clean git histories. Also, I'm happy to
 help, and polish the git history to the best of my abilities! Do you want
 me to make a pass over it?

 Finally, we should take care of the following remark, which seems to be an
 actual bug:
 > The last line in ​61973769 should probably be print_footer() and not
 print_footer.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28152#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs