[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #34211 [Core Tor/Tor]: Add support for control signals (ex. Ctrl+C) in Windows



#34211: Add support for control signals (ex. Ctrl+C) in Windows
-------------------------------------------------+-------------------------
 Reporter:  TheDcoder                            |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:                                       |  Actual Points:
  control,termination,signals,windows,winapi     |
Parent ID:                                       |         Points:
 Reviewer:  ahf                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:5 TheDcoder]:
 > Replying to [comment:4 ahf]:
 >
 > > I think the patch looks fine, but could I get you to create a pull-
 request against our master branch on https://github.com/torproject/tor ?
 This would allow us to verify that the code passes our test-suites and is
 mergeable.
 >
 > Great to know that the patch looks fine. I will certainly create a pull-
 request, though it looks like GitHub's user interface only allows PRs from
 "forks", my repository is not considered a fork because I had cloned it
 from gitweb.torproject.org and then pushed it to a repository under my
 user account. So I need to figure out how to create a pull-request.

 Yes, that's an annoying limitation of GitHub.

 When that's happened to me, I've created a fork under another name, and
 used that fork. (You can also rename and archive the old repository. Then
 you can push all your branches to a new fork under the correct name.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34211#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs