[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #33222 [Core Tor/Tor]: Prop 311: 4.2. Implement IPv6 ORPort Reachability Self-Tests

#33222: Prop 311: 4.2. Implement IPv6 ORPort Reachability Self-Tests
---------------------------+------------------------------------
 Reporter:  teor           |          Owner:  teor
     Type:  enhancement    |         Status:  needs_review
 Priority:  Medium         |      Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor   |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:  ipv6, prop311  |  Actual Points:  4
Parent ID:  #33221         |         Points:  6
 Reviewer:  nickm          |        Sponsor:  Sponsor55-must
---------------------------+------------------------------------
Changes (by teor):

 * actualpoints:  3 => 4


Comment:

 I have pushed some extra tests and changes files:
 * master: https://github.com/torproject/tor/pull/1874

 This branch also fixes the following Rust protover bugs in master:
 * #34248: add HSIntro=5 in Rust
 * #34251: fix error handling in Rust protover is supported
 I've left those tickets open, because we need to backport those changes.

 Here are the features and functions that don't have unit tests:
 * launch IPv6 ORPort self-test circuits
   * fmt_addr32_port()
   * fmt_af_family() - refactoring
   * fmt_addr_family() - refactoring
   * router_get_orport()
   * extend_info_from_router()
   * router_do_orport_reachability_checks()
   * router_do_dirport_reachability_checks() - minor modifications and
 refactoring
   * router_do_reachability_checks() - minor modifications and refactoring
   * inform_testing_reachability() - minor modifications and refactoring
 * when launching IPv6 ORPort self-test circuits, make sure that the last
 hop supports IPv6 extends
   * node_supports_initiating_ipv6_extends()
   * node_supports_accepting_ipv6_extends()
   * router_add_running_nodes_to_smartlist() - added IPv6 extend check

 These tests should be much easier to write on top of the refactor in
 #34200.

 This code runs in chutney's IPv6 networks, which are part of Tor's CI. But
 chutney doesn't fully test IPv6 reachability yet. Chutney will test more
 of this code, when we split tor's IPv4 and IPv6 reachability flags in
 #34067.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33222#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs