[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #34300 [Applications/GetTor]: Ensure GetTor's email unit tests are properly formatted



#34300: Ensure GetTor's email unit tests are properly formatted
-------------------------------------+--------------------
     Reporter:  cohosh               |      Owner:  (none)
         Type:  defect               |     Status:  new
     Priority:  Medium               |  Milestone:
    Component:  Applications/GetTor  |    Version:
     Severity:  Normal               |   Keywords:
Actual Points:                       |  Parent ID:
       Points:                       |   Reviewer:
      Sponsor:                       |
-------------------------------------+--------------------
 From #34286:

 [comment:3 phw]:
 > Looks good to me!
 >
 > On a slightly related note: I believe that an email's body is supposed
 to be separated by two (rather than one) newlines from its header.
 GetTor's unit tests are using only one (and mix \n with \r\n). Python's
 email module is also confused by this and thinks that the body is part of
 the `To` field:
 >
 > {{{
 > In [1]: from email import message_from_string
 > In [3]: m=message_from_string("From: MAILER-
 DAEMON@xxxxxxxxxxxxxx\nSubject: Undelivered Mail Returned to Sender\r\nTo:
 gettor@xxxxxxxxxxxxxx\n osx en\n")
 > In [6]: m.items()
 > Out[6]:
 > [('From', 'MAILER-DAEMON@xxxxxxxxxxxxxx'),
 >  ('Subject', 'Undelivered Mail Returned to Sender'),
 >  ('To', 'gettor@xxxxxxxxxxxxxx\n osx en')]
 > }}}
 >
 > This seems like something we should fix.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34300>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs