[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #1983 [Tor Relay]: Port tor-fw-helper to Windows

#1983: Port tor-fw-helper to Windows
----------------------------+-----------------------------------------------
    Reporter:  ioerror      |       Owner:  sjmurdoch         
        Type:  enhancement  |      Status:  assigned          
    Priority:  major        |   Milestone:  Tor: 0.2.3.x-final
   Component:  Tor Relay    |     Version:  Tor: unspecified  
  Resolution:               |    Keywords:                    
      Parent:  #1775        |      Points:                    
Actualpoints:               |  
----------------------------+-----------------------------------------------
Changes (by nickm):

  * status:  needs_review => assigned


Comment:

 Merging those too.  But you've got more problems in
 wait_until_fd_readable(): the right type for a socket on windows is
 SOCKET, which is "unsigned int" on 32-bit platforms, but "UINT_PTR" on
 64-bit windows.

 This might be more pervasive than just that function, if the code is using
 "int" to hold sockets elsewhere.

 (Also, select() only works on sockets on windows, but I think you're
 giving it a socket, so that's ok)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1983#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs