[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7499 [Stem]: Unit test bug - mocking.py:_get_descriptor_content() handlign of 'opt' keyword



#7499: Unit test bug - mocking.py:_get_descriptor_content() handlign of 'opt'
keyword
--------------------+-------------------------------------------------------
 Reporter:  eoinof  |          Owner:  atagar
     Type:  defect  |         Status:  new   
 Priority:  normal  |      Milestone:        
Component:  Stem    |        Version:        
 Keywords:          |         Parent:        
   Points:          |   Actualpoints:        
--------------------+-------------------------------------------------------

Comment(by atagar):

 Right on all counts. However, this would only pose a problem if a test
 tried to include multiple 'opt' lines, and none of the server_descriptor
 unit tests do.

 Maybe we should simply note in get_relay_server_descriptor() and
 get_bridge_extrainfo_descriptor() pydocs that to have multiple opt lines
 the caller should omit the 'opt' keyword then call replace(keyword + ' ',
 'opt %s ' % keyword) on the returned result?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7499#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs