[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #7515 [Tor]: Better definition for ADDRMAP events

#7515: Better definition for ADDRMAP events
--------------------+-------------------------------------------------------
 Reporter:  atagar  |          Owner:     
     Type:  defect  |         Status:  new
 Priority:  normal  |      Milestone:     
Component:  Tor     |        Version:     
 Keywords:          |         Parent:     
   Points:          |   Actualpoints:     
--------------------+-------------------------------------------------------
 The ADDRMAP specification is making me twitch for a few reasons...

 * It doesn't say what the events do. My guess from seeing a few is that it
 simply indicates DNS resolution. However, the spec doesn't make this clear
 and it allows hostnames to be resolved to other hostnames (I'm guessing
 that is a mistake).

 * The errors are undefined. An 'XXXX' is pretty bad - I hope we can at
 least say what the error code can include.

 * The spec summary has some mistakes. For instance, it doen't list
 GMTExpiry as being optional (despite saying so below), and it should make
 it clear that 'error' and 'GMTExpiry' are key/value entries. My first
 thought when I saw this event was "WTF? They have an optional positional
 argument?!? Gah!"

 Patch is available in my 'addrmap' branch...
 https://gitweb.torproject.org/user/atagar/torspec.git/commitdiff/0168f7d58aaf4d8d840407f1b3420218ee2d3eeb

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7515>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs