[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9454 [TorBrowserButton]: The nsIPluginTag Interface was changed, Torbutton is broken for next Firefox ESR

#9454: The nsIPluginTag Interface was changed, Torbutton is broken for next
Firefox ESR
----------------------------------+----------------------------------------
     Reporter:  cypherpunks       |      Owner:  mikeperry
         Type:  defect            |     Status:  needs_revision
     Priority:  normal            |  Milestone:
    Component:  TorBrowserButton  |    Version:
   Resolution:                    |   Keywords:  ff24-esr, MikePerry201311R
Actual Points:                    |  Parent ID:
       Points:                    |
----------------------------------+----------------------------------------

Comment (by mcs):

 Replying to [comment:11 mikeperry]:
 > However, I am curious why mcs chose to check the state before setting
 the attribute? Does this reduce spurious 'xpcom-category-entry-added'
 observer events? Or some other reason? If it is in fact needed for some
 reason, we should comment the code with that reason.

 We basically followed the intent behind the older code (check that a real
 change is being made before setting the plugin state).  I do think this
 approach will avoid some notifications; maybe 'plugin-info-updated'?
 Kathy and I will verify and then add an appropriate comment.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9454#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs