[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13776 [Tor Browser]: Generation of incremental mar files is not reproducbile

#13776: Generation of incremental mar files is not reproducbile
-----------------------------+------------------------
     Reporter:  gk           |      Owner:  tbb-team
         Type:  defect       |     Status:  new
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:               |   Keywords:  tbb-gitian
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+------------------------

Comment (by mcs):

 The root cause of the problem appears to be a locale difference that
 causes case-insensitive sort for the mikeperry build (there may also be
 differences in how punctuation characters are handled).  Almost certainly
 the correct fix is to set LC_ALL=C somewhere.

 In the short run, maybe just try setting it before running the make
 command, e.g.,
   LC_ALL=C make incrementals

 The problem does not occur for full MARs because those are generating
 inside a VM.

 A real fix would require adding LC_ALL=C inside the incrementals target
 within gitian/Makefile.  Or we could modify Mozilla's scripts to set the
 locale (tools/update-packaging/make_incremental_update.sh and, for
 safety's sake, make_full_update.sh).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13776#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs