[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17253 [Tor]: Revise tests in test_tortls.c to not act intrusively on openssl internals

#17253: Revise tests in test_tortls.c to not act intrusively on openssl internals
------------------------------+------------------------------------
 Reporter:  nickm             |          Owner:
     Type:  defect            |         Status:  new
 Priority:  Medium            |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor               |        Version:
 Severity:  Normal            |     Resolution:
 Keywords:  testing SponsorS  |  Actual Points:
Parent ID:                    |         Points:
  Sponsor:                    |
------------------------------+------------------------------------
Changes (by rubiate):

 * severity:   => Normal


Comment:

 I could not get it to build with LibreSSL as
 `test_tortls_client_is_using_v2_ciphers()` calls `get_cipher_by_name()`
 which has its definition ifndef'd out. I am guessing this is because
 LibreSSL does not have `SSL_get_client_ciphers()` so it follows the #else
 block whereas OpenSSL doesn't.

 The attached patch makes it build successfully by also indef'ing out
 test_tortls_client_is_using_v2_ciphers()

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17253#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs