[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17446 [Tor Browser]: Canvas image extraction prompt logic

#17446: Canvas image extraction prompt logic
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  Medium                               |         Status:
Component:  Tor Browser                          |  needs_revision
 Severity:  Normal                               |      Milestone:
 Keywords:  tbb-fingerprinting,                  |        Version:
  PearlCrescent201511R, TorBrowserTeam201511R    |     Resolution:
Parent ID:                                       |  Actual Points:
  Sponsor:                                       |         Points:
-------------------------------------------------+-------------------------
Changes (by mcs):

 * status:  needs_review => needs_revision


Comment:

 Kathy and I reviewed this and the logic seems correct. A couple of small
 things:
 a) Please replace "Blocked third party %s from extract canvas data." with
 "Blocked third party %s from extracting canvas data."
 (s/extract/extracting)
 b) It would be better to keep the console messages as one message instead
 of two (better for filtering the console output).
 c) We should continue to log both the first party URI and the doc URI when
 canvas access is blocked. Otherwise it is difficult for end-users to
 figure out what was blocked on what page.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17446#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs