[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17183 [Tor]: Add exit-policy/reject-private so stem can discover ExitPolicyRejectPrivate rules



#17183: Add exit-policy/reject-private so stem can discover ExitPolicyRejectPrivate
rules
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  enhancement                          |         Status:
 Priority:  Medium                               |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  stem, 028-triaged,                   |        Version:  Tor:
  TorCoreTeam201511                              |  unspecified
Parent ID:                                       |     Resolution:
  Sponsor:                                       |  Actual Points:
                                                 |         Points:  small
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  reopened => needs_review


Comment:

 Thank you for catching both of these issues.

 My branch fix-policies-memory contains fixes for both issues mentioned in
 the previous comment:
 * copy the addresses before adding them to the smartlist, then have the
 caller free them when the smartlist is freed (and update the function
 names and comments to make this explicit)
 * fix a memory leak in the getinfo_helper_policies test: the attached
 patch applied using 'git am'

 I am sorry that this patch has needed so many fixes - I introduced the
 use-after-stack-return issue when I refactored the functions in
 [comment:13 getinfo-private-exitpolicy-v4 in comment 13].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17183#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs