[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #16943 [Tor]: Implement prop250 (Random Number Generation During Tor Voting)
#16943: Implement prop250 (Random Number Generation During Tor Voting)
----------------------+------------------------------------
Reporter: asn | Owner:
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.2.8.x-final
Component: Tor | Version:
Severity: Blocker | Resolution:
Keywords: tor-hs | Actual Points:
Parent ID: #8244 | Points: large
Sponsor: SponsorR |
----------------------+------------------------------------
Comment (by asn):
Replying to [comment:15 dgoulet]:
> Latest branch with code rebased on master and improvement: `prop250_v4`.
>
Great! Please also check my `prop250_v4` branch. Based on yours with a few
mods.
Specifically:
- Some small code tweaks and variable/function renames.
- I removed the disaster formula. It's not useful anymore. Please see
commit message for more info.
- Made the vote parsing logic a bit more robust, I hope.
- I renamed and changed the semantics of `NumSRParticipants`. Now, instead
of using it just to count the number of participants, we use it to reject
SRVs that have been voted by less than `NumSRParticipants` dirauths. This
makes us more robust against edge cases like the one where the 5th SR
dirauth appears during the reveal phase and calculates a different SRV
than the other 4.
- Also, now on the majority calculation, I use the total number of
dirauths instead of the number of voters. I did this to mirror the way the
`n_required` works in `networkstatus_check_consensus_signature()`.
Let me know if you find these things reasonable!!!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16943#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs