[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17975 [Core Tor/Tor]: Introduce OutboundExitAddress to enable exit-only traffic to go via a different IP address
#17975: Introduce OutboundExitAddress to enable exit-only traffic to go via a
different IP address
-------------------------------------------------+-------------------------
Reporter: naif | Owner:
Type: enhancement | Status:
| needs_revision
Priority: Low | Milestone: Tor:
| 0.3.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: lorax, yawning, isaremoved, review- | Actual Points:
group-11 |
Parent ID: | Points: 1
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):
* status: needs_review => needs_revision
Comment:
Notes:
* Changes file should mention the ticket number.
* Commit message should mention the author.
* parse_outbound_addresses has gotten really complicated, and full of
duplicate code. Maybe it's possible to refactor it to be cleaner? This
"adr_found[i]" stuff is fairly inelegant.
* Would it make more sense to have the syntax be "OutboundBindAddress
Exit 1.2.3.4" ?
* conn_get_outbound_address falls back to the Exit address when the OR
address is null. That doesn't make sense to me. Why did the user say
OutboundBindAddressExit if they meant OutboundBindAddress?
* Other outbound connection types are possible. For example, directory
connections, DNS lookups, and local connections to hidden services.
Should those get handled too? Should they get treated as if they were
exit?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17975#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs