[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20596 [Metrics]: add jdk version to manifest files

#20596: add jdk version to manifest files
-------------------------+--------------------------
 Reporter:  iwakeh       |          Owner:  iwakeh
     Type:  enhancement  |         Status:  assigned
 Priority:  Medium       |      Milestone:
Component:  Metrics      |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:
-------------------------+--------------------------

Comment (by karsten):

 The remaining parts that don't make immediate sense are:

  - Why add two modules `SuppressWarningsFilter` and
 `SuppressWarningsHolder`?  Those are not explained in the changes section.
 Do we need both, and why?

  - Can you prepare a patch for, say, metrics-lib's `metrics_checks.xml` as
 complete version with all changes and documentation why we're making those
 changes and which checkstyle issues are affected in brackets, that we can
 use to discuss and later copy over to the other four code bases?

  - Can you submit a patch for metrics-lib's `build.xml` with the various
 suggestions in comments 2 to 6 above?  I'm afraid I lost track which of
 them should go where.

 Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20596#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs