[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20764 [Core Tor/Tor]: Duplicate memset call in tor_addr_from_sockaddr

#20764: Duplicate memset call in tor_addr_from_sockaddr
----------------------------+------------------------------------
 Reporter:  icanhasaccount  |          Owner:
     Type:  defect          |         Status:  merge_ready
 Priority:  Very Low        |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Trivial         |     Resolution:
 Keywords:                  |  Actual Points:
Parent ID:                  |         Points:  0.1
 Reviewer:                  |        Sponsor:
----------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * points:   => 0.1
 * milestone:   => Tor: 0.3.0.x-final


Comment:

 I think this is fine. However, it means that `tor_addr_from_sockaddr()`
 now relies on its inner functions to wipe the `tor_addr_t *a` so if any
 "else if" is added later, we must be very careful.

 For this reason, I'm not too bothered by that extra memset() but I'll let
 nickm judge this if he wants to merge it or not. Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20764#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs