[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8298 [Core Tor/Tor]: Do not start write to connection if blocked on bw

#8298: Do not start write to connection if blocked on bw
--------------------------------------------+------------------------------
 Reporter:  cypherpunks                     |          Owner:
     Type:  defect                          |         Status:
                                            |  needs_revision
 Priority:  Low                             |      Milestone:  Tor: 0.3.???
Component:  Core Tor/Tor                    |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  kludgy, tor-relay, nickm-patch  |  Actual Points:
Parent ID:                                  |         Points:  0.1
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------
Changes (by dgoulet):

 * keywords:  kludgy, tor-relay, 024-deferrable, nickm-patch => kludgy, tor-
     relay, nickm-patch
 * status:  needs_review => needs_revision
 * points:   => 0.1


Comment:

 I believe this should be as the definition of `write_blocked_on_bw`
 mentions that it's true iff we are allowed to write.

 {{{
 +  if (conn->write_event && conn->write_blocked_on_bw) {
 }}}

 {{{
   unsigned int write_blocked_on_bw:1; /**< Boolean: should we start
 writing
                              * again once the bandwidth throttler allows
                              * writes? */
 }}}

 `assert_connection_ok()` uses it that way.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8298#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs