[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31130 [Applications/Tor Browser]: Use Debian 10 for our Android container images



#31130: Use Debian 10 for our Android container images
-------------------------------------------+-------------------------------
 Reporter:  gk                             |          Owner:  tbb-team
     Type:  defect                         |         Status:
                                           |  needs_revision
 Priority:  Medium                         |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201911  |  Actual Points:
Parent ID:  #31127                         |         Points:  0.5
 Reviewer:                                 |        Sponsor:
-------------------------------------------+-------------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-rbm, TorBrowserTeam201911R => tbb-rbm,
               TorBrowserTeam201911


Comment:

 Some comments:

 1) This ticket is about using Debian 10 for our Android containers and
 #31992 is about removing our `apktool` workaround. Yet, it seems you are
 essentially mixing both issues in one commit saying it fixes #31110 which
 is confusing. Could we have two commits here one for #31110 (that is
 upgrading to `buster`) and one (on top of it) for #31992? Ideally, the
 build would still work if each commit would be used for building.

 2) Please remove the whitespace at the end of
 {{{
 +          JDK_VERSION=8u232-b09-1~deb9u1_amd64
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31130#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs