[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30683 [Applications/Tor Browser]: Properties in dom/locales/$lang/chrome/ allow detecting user locale

#30683: Properties in dom/locales/$lang/chrome/ allow detecting user locale
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-fingerprinting-locale            |  Actual Points:  1
  TorBrowserTeam201911R                          |
Parent ID:                                       |         Points:  0.25
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:26 acat]:
 > Backported in https://github.com/acatarineu/tor-
 browser/commits/30683_backport.

 Looks mostly good. I am a bit confused why we need the
 `FormatMaybeLocalizedString()` version with `const nsTArray<nsString>&
 aParamArray`. As far as I can see none of the changed code is using that
 one. The patch is already large, thus, could you trim it accordingly if I
 am not being wrong here?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30683#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs