Re: [tor-bugs] #32475 [Applications/Tor Browser]: Reduce the number of locales we provide updates for in nightly

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#32475: Reduce the number of locales we provide updates for in nightly
-------------------------------------------------+-------------------------
 Reporter:  boklm                                |          Owner:  boklm
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-update,                 |  Actual Points:
  TorBrowserTeam201911, ux-team                  |
Parent ID:  #18867                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor9
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-rbm, tbb-update, TorBrowserTeam201911R, ux-team => tbb-
     rbm, tbb-update, TorBrowserTeam201911, ux-team


Comment:

 Replying to [comment:10 boklm]:
 > I pushed a new revision of the patch in branch `bug_32475_v3`:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_32475_v3&id=0327f0a0676d6a377f4f8b042bb5d34247d9cd94
 >
 > This removes the hack that was used to check if a locale is in the
 `mar_locales` list.

 The update generation is following our bundle generation which is kind of
 split in two parts. The first part is used for `en-US` which is shipping
 no lang packs. The second part is used for all the other locales which
 ship with the respective lang pack.

 It's confusing that you only patch the second part but include en-US in
 the `mar_locales` given that `en-US` is *not* in `var/locales`. I guess we
 might got lucky as I can still see things working (the `en-US` .mar gets
 built in the first part as `var/build_mar` is defined but gets ignored in
 your patch because `IF mar_lang == lang;` is never `true`. I find it
 error-prone as well that we continue to use at one hand `[% IF
 c("var/build_mar") -%]` and at the other hand `[% IF build_mar -%]` for
 deciding whether to create full .mar files or not.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32475#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs