[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4229 [Tor Client]: smartlist_len returns a (signed) int

#4229: smartlist_len returns a (signed) int
------------------------+---------------------------------------------------
 Reporter:  rransom     |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  major       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 If we're going to change the return type of smartlist_len() {or even if
 we're not}, we need to be prepared to audit all 448 places that uses it,
 to make sure it behaves right given an unsigned or a size_t or whatever.

 As a stopgap, perhaps we should just ensure that a smartlist's size can't
 grow larger than INT_MAX ?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4229#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs