[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7250 [Stem]: skip test if consensus file not found



#7250: skip test if consensus file not found
------------------------+---------------------------------------------------
    Reporter:  gsathya  |       Owner:  atagar
        Type:  defect   |      Status:  closed
    Priority:  minor    |   Milestone:        
   Component:  Stem     |     Version:        
  Resolution:  fixed    |    Keywords:        
      Parent:           |      Points:        
Actualpoints:           |  
------------------------+---------------------------------------------------
Changes (by atagar):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 It already tries...

 {{{
 if not os.path.exists(consensus_path):
   test.runner.skip(self, "(no cached-microdesc-consensus)")
 elif stem.util.system.is_windows():
   test.runner.skip(self, "(unavailable on windows)")
   return
 }}}

 https://gitweb.torproject.org/stem.git/blob/HEAD:/test/integ/descriptor/networkstatus.py#l59

 The trouble is that we're not returning after we call skip(), which causes
 us to still fail on python 2.5 and 2.6.

 Fixed...
 https://gitweb.torproject.org/stem.git/commitdiff/89ec87cfa3c119d96ee32d7debec0dde9e97cb51

 Anything that I can do to persuade you to not only report issues but also
 patches? ;)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7250#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs