[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #6877 [Tor]: Finally replace all char[] buffers with uint8_t[] buffers

#6877: Finally replace all char[] buffers with uint8_t[] buffers
------------------------+--------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  major   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-client
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by nickm):

 c48c2fb5979ad7189fb9f37a25e250e9379ad9eb:
   * Looks okay.
   * For crypto_digest_smartlist, since it's defined to take a list of NUL-
 terminated strings, I think it makes sense to have them remain char*.

 24f08854b9e3efa94158ccb9b1f161f1a27b5e4a:
   * Wow, that's a big one...
   * In dirvote.c, since fingerprint is a hex string, it probably makes
 sense to have it stay char.
   * Otherwise looks okay.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6877#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs