[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13135 [Onionoo]: Support various fingerprint formats



#13135: Support various fingerprint formats
-----------------------------+--------------------------
     Reporter:  Sebastian    |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Onionoo      |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------

Comment (by iwakeh):

 The branch looks fine. (No problems when running it locally, but I had to
 start with fresh data.)

 In SummaryDocument (catch-statements around lines 52 and  65)
 I'd rather log the DecoderException instead of totally ignoring it.
 The DigestUtils or Base64 class could malfunction, or some other problem
 could happen. In such a case, there would be a hint in the log.

 And the version in ResponseBuilder needs to be increased before the
 release.

 The first time for using 'next_major_version_scheduled' :-)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13135#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs