[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13476 [Tor]: time handling - bug fixes, extra external input checks, and unit tests

#13476: time handling - bug fixes, extra external input checks, and unit tests
------------------------+--------------------------------
     Reporter:  teor    |      Owner:
         Type:  defect  |     Status:  needs_revision
     Priority:  minor   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:  Tor: unspecified
   Resolution:          |   Keywords:  tor-router
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 This looks okay to me, except for the unit tests that do `if
 (sizeof(a_time.tm_year) == 8)`. Because that code is compiled
 unconditionally, I get warnings when I build it on my system where
 `sizeof(a_tm.tm_year)` is only 4.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13476#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs